Release 0.20.3 #13186
Release 0.20.3 #13186
Conversation
* Reuse intro from contributing.rst * Removed content already on rst Simplified CONTRIBUTING.md by removing content that already exists in contributing.rst. Added Code of Conduct reference as seen in a few other CONTRIBUTING.md of popular libraries. * Update contributing.rst In shortening `CONTRIBUTING.md`, material deleted from `how to contribute` section are added onto `contributing.rst` if it doens't exist on the latter. * added full link to .rst file + removed 'Full' in 'Full Docum...'
* Added tips for reading the code base * Put it in contributing.rst * Added bullet point about inheritance
With thanks to @rishikksh20 and @ml4713
…handle_unknown='ignore' case (scikit-learn#12923)
…r._get_column_indices (scikit-learn#13017)
|
Maybe we can cherry-pick 2480368 here, since it's important to let users know that we have a new OneHotEncoder. |
|
Happy to delay until the end of the sprint if we can fix the ARM issues |
…ransformer examples (scikit-learn#13212)
* add governance doc * add links to docs * minor formatting, more links * Update doc/governance.rst fix broken link Co-Authored-By: amueller <t3kcit@gmail.com> * Apply suggestions from code review Co-Authored-By: amueller <t3kcit@gmail.com> * reframed with call for vote. I think this is good. * make it easier to call a vote. * Update doc/governance.rst rephrasing Co-Authored-By: amueller <t3kcit@gmail.com> * link governance from the about page instead on documentation.rst
* fix bug in graph lasso * better fix * add test for case n_features=2 * remove test for deprecated version * update whats new * note that the bug was a regression
|
@rth let me know if there are other fixes for ARM we want to make. It'd be nice if we can release this over coming days (I'd hoped for February, but it doesn't really make sense to waste sprint time on this) |
|
Maybe we could apply the hotfix in #13323 ? Apart from that +1 for 0.20.3 release. |
|
Any last requests/reviews for the release? We could push this out today, or wait for a week or two |
|
Still two 0.20.3 issues? |
|
We aren't yet able to reproduce them. We have no access at present to ARM
32bit systems, though @glemaitre was tasked with opening a conversation
with Shippable.
Existence of issues does not block a release. Though if we had promised
support for ARM 32, I might consider those blockers.
|
Agree, someone should untag these issues before the release. |
9e39bec to
46df5b3
Compare
<!-- Thanks for contributing a pull request! Please ensure you have taken a look at the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist --> #### Reference Issues/PRs Fixes scikit-learn#13103 <!-- Example: Fixes scikit-learn#1234. See also scikit-learn#3456. Please use keywords (e.g., Fixes) to create link to the issues or pull requests you resolved, so that they will automatically be closed when your pull request is merged. See https://github.com/blog/1506-closing-issues-via-pull-requests --> #### What does this implement/fix? Explain your changes. This PR updates the variable named _RE_ESCAPE_CHARS in _arff.py file line number 168. This updation happens in order to match it with this file(https://github.com/renatopp/liac-arff/blob/master/arff.py) in liac-arff. #### Any other comments? <!-- Please be aware that we are a loose team of volunteers so patience is necessary; assistance handling other issues is very welcome. We value all user contributions, no matter how minor they are. If we are slow to review, either the pull request needs some benchmarking, tinkering, convincing, etc. or more likely the reviewers are simply busy. In either case, we ask for your understanding during the review process. For more information, see our FAQ on this topic: http://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention. Thanks for contributing! -->
…earn#13312) * Memory usage of OpenML fetcher: use generator from arff * fix actually getting data qualities in all cases * Add qualities responses * add workaround for cases where data qualities are not available * feedback joel
|
Happy to just pursue release today if that's what we think we should do... |
If we can release that would be great, so we can focus better on v0.21 next... |
|
Tbh I have to little overview of what's happening to really have an informed opinion. So we're not resolving some of the debian stuff? |
|
I think we need to aim to resolve the ARM 32 issues for version 0.21 as we
don't have a machine to do that on yet.
|
I've gone through the what's new so far, plus the PRs closed in https://github.com/scikit-learn/scikit-learn/milestone/29. I pulled in several doc changes too. Included patches so far:
TO DO before merge:
TO DO after merge
Interactive rebase list:
Plus another few things at the end.