Skip to content

[MRG] Fix doctest failure #13249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 25, 2019
Merged

[MRG] Fix doctest failure #13249

merged 2 commits into from
Feb 25, 2019

Conversation

jeremiedbb
Copy link
Member

@jeremiedbb jeremiedbb commented Feb 25, 2019 •
edited
Loading

The extract_patches_2d doctest fails on some but not all CIs. It's due to the fact that the ordering of the output of os.listdir(...) is not the same on the different CIs. I propose to load an explicit image in the docstring example instead.

ping @glemaitre

@qinhanmin2014
Copy link
Member

@jeremiedbb please add the print statement back, see #13238
LGTM if CIs are green

@qinhanmin2014 qinhanmin2014 mentioned this pull request Feb 25, 2019
Merged
@jeremiedbb jeremiedbb force-pushed the fix-extract-patches-docstring branch from 44bb237 to 4ee0093 Compare February 25, 2019 14:26
@jnothman
Copy link
Member

I'm sure we should be using sorted in load_sample_images

@jnothman jnothman merged commit 7a09951 into scikit-learn:master Feb 25, 2019
@qinhanmin2014
Copy link
Member

@jnothman we have #13250, which seems better :)

@jeremiedbb
Copy link
Member Author

Both are good :)
#13250 is necessary to have determism in load_sample_images, but this gives a more readable example to me. So keeping both is fine, no ?

@qinhanmin2014
Copy link
Member

#13250 is necessary to have determism in load_sample_images, but this gives a more readable example to me. So keeping both is fine, no ?

I agree

xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
@jeremiedbb
DOC Fix extract_patches_2d doctest failure (scikit-learn#13249)
11c8c03
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "DOC Fix extract_patches_2d doctest failure (scikit-learn#13249)"
b402114 
This reverts commit 11c8c03.
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "DOC Fix extract_patches_2d doctest failure (scikit-learn#13249)"
0f015a4 
This reverts commit 11c8c03.
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@jeremiedbb @koenvandevelde
DOC Fix extract_patches_2d doctest failure (scikit-learn#13249)
24e9d44
@jeremiedbb jeremiedbb deleted the fix-extract-patches-docstring branch July 20, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremiedbb @qinhanmin2014 @jnothman