-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
[MRG] Adds Azure Tests For Windows 32 bit Python 3.5 #13296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BUG Fix ENH Enclude output ENH Include installation ENH Include installation ENH Include installation ENH Include installation ENH Include installation ENH Include installation ENH Include installation ENH Include installation ENH Include installation ENH Include installation ENH Include installation ENH Include installation ENH Include installation ENH Include installation ENH Include installation ENH Include installation ENH Include installation ENH Include installation ENH Include installation ENH Include installation ENH Include installation ENH Include installation
jnothman
approved these changes
Feb 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise lgtm
ogrisel
approved these changes
Feb 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well, thanks @thomasjpfan!
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…learn#13296)" This reverts commit 0a82ef0.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…learn#13296)" This reverts commit 0a82ef0.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
See also #13284
See also #13293
What does this implement/fix? Explain your changes.
Uses the system 32-bit Python 3.5 on Windows. This puts the test closer to the target audience of this test: users that install Python 32-bit from python.org. (Since it is the default)
Any other comments?
With this update, we can now remove appveyor from our CI.