Skip to content

[MRG] Adds Azure Tests For Windows 32 bit Python 3.5 #13296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 28, 2019

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

See also #13284
See also #13293

What does this implement/fix? Explain your changes.

Uses the system 32-bit Python 3.5 on Windows. This puts the test closer to the target audience of this test: users that install Python 32-bit from python.org. (Since it is the default)

Any other comments?

With this update, we can now remove appveyor from our CI.

BUG Fix

ENH Enclude output

ENH Include installation

ENH Include installation

ENH Include installation

ENH Include installation

ENH Include installation

ENH Include installation

ENH Include installation

ENH Include installation

ENH Include installation

ENH Include installation

ENH Include installation

ENH Include installation

ENH Include installation

ENH Include installation

ENH Include installation

ENH Include installation

ENH Include installation

ENH Include installation

ENH Include installation

ENH Include installation

ENH Include installation

ENH Include installation
@thomasjpfan thomasjpfan changed the title [MRG] Adds Azure Tests For Windows 32 bit Python 3.6 [MRG] Adds Azure To Tests Windows 32 bit Python 3.5 Feb 27, 2019
@thomasjpfan thomasjpfan changed the title [MRG] Adds Azure To Tests Windows 32 bit Python 3.5 [MRG] Adds Azure Tests For Windows 32 bit Python 3.5 Feb 27, 2019
Copy link
Member

@jnothman jnothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise lgtm

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well, thanks @thomasjpfan!

@ogrisel ogrisel merged commit 3f0c5fe into scikit-learn:master Feb 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants