Skip to content

MNT release 0.21.0 #13804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
May 9, 2019
Merged

MNT release 0.21.0 #13804

merged 27 commits into from
May 9, 2019

Conversation

jnothman
Copy link
Member

@jnothman jnothman commented May 6, 2019

Here are changes accumulated for 0.21.0 final. This PR currently proposes release on Thursday, when I might have the chance to facilitate it, eight days after RC. Are there reasons wait longer for release?

I'll await for approvals here either way.

drop 0b3aa5e466 DOC bump version
drop 10249939e5 DOC move 0.20 to previous releases
drop e7bd8a33e5 FIX Optics paper typo which resulted in undersized clusters (#13750)
pick 5f0263fe7f BLD Fixes Cython cimport errors (#13754)
pick e7ca6236c5 Fix spacing and formatting inconsistencies (#13747)
pick 9d5dd3e967 DOC Updating PolynomialFeatures.Transform docstring (#13755)
pick 175ded7caa DOC: trivial rst fix (#13765)
pick 068bcae2f5 DOC: fix class ref (#13766)
pick 4de404d46d MNT Cleaning for fast partial dependence computation (#13738)
drop 384c8ad3d3 ENH add a break_ties parameter to SVC and NuSVC (#12557)
pick b9c3d87dd9 [MRG] DOC: Fix unusual phrasing in svm.SVC (#13774)
pick f84a5feb2a [MRG] DOC Added version information for PCA.singular_values_ (#13776)
pick 28728f5c79 DOC add example to IsotonicRegression class (#13768)
pick 0dac63f48c ENH Ridge with solver SAG/SAGA does not cast to float64 (#13302)
pick 3373e9c125 Fixed documentation for mean_precision_prior.  Smaller->Larger (#13764)
pick 612a04e4e4 DOC Fix more formatting inconsistencies (#13787)
pick 519bedc70e DOC Fix note range in contributing.html (#13722)
drop 13981bdce9 STY Remove variable renaming (#13731)
pick b34751b7ed [MRG] MAINT: add fixture for init and clean-up with matplotlib (#13708)
pick 8d3b4ff3ee FIX Allow to disable estimator and passing weight in Voting estimators (#13779)
pick 1e2e8471fb API use 'drop' to disable estimators in voting  (#13780)

@jnothman
Copy link
Member Author

jnothman commented May 8, 2019

Pending inclusion or exclusion of #13824, can I please get confirmation that we are happy to release over the next day or two, @scikit-learn/core-devs ? Thanks.

@glemaitre
Copy link
Member

I think that #13816 needs to be backported since #13302 has been merged.

@jnothman
Copy link
Member Author

jnothman commented May 8, 2019 via email

@TomDLT
Copy link
Member

TomDLT commented May 8, 2019

I like #13824. Nothing blocking the release on my side, thanks for your fantastic work !

@jnothman
Copy link
Member Author

jnothman commented May 8, 2019

After merge:

@jnothman
Copy link
Member Author

jnothman commented May 9, 2019

Forgot that we want to update the roadmap, per #13809, too.

@qinhanmin2014
Copy link
Member

Is it possible to remove the experimental tag in ColumnTransformer (and fetch_openml maybe)? I don't like the inconsistency between experimental features.
For fetch_openml, we said that "The API is experimental in version 0.20". I think we should at least update the note.
We tag ColumnTransformer as experimental, but we still use a deprecation cycle when we change the API interface of make_column_transformer, so I'm still confused about the definition of experimental.

@jnothman
Copy link
Member Author

jnothman commented May 9, 2019

We tag ColumnTransformer as experimental, but we still use a deprecation cycle when we change the API interface of make_column_transformer, so I'm still confused about the definition of experimental.

The problem there was partially that our core devs had been teaching with an experimental interface, so TBH, we were merely protecting our own. I think the explicit consent we have now introduced mitigates this unclarity.

I'm okay with removing experimental tag from ColumnTransformer. Make a PR?

I'd leave it on fetch_openml. There I think we might still want to change how we handle heterogeneous types etc by default. I agree it's inconsistent in terms of how experimental is demonstrated in the API, but we can't change history.

@qinhanmin2014
Copy link
Member

@jnothman If we want to change the API of an experimental feature, do we need a deprecation cycle?

@jnothman
Copy link
Member Author

jnothman commented May 9, 2019

If we want to change the API of an experimental feature, do we need a deprecation cycle?

No, but we can still choose to have one.

@jnothman jnothman merged commit 39c74cd into scikit-learn:0.21.X May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.