Skip to content

[MRG] Make modules private in semi_supervised #15317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 22, 2019
Merged

[MRG] Make modules private in semi_supervised #15317

merged 4 commits into from
Oct 22, 2019

Conversation

thomasjpfan
Copy link
Member

@thomasjpfan thomasjpfan commented Oct 21, 2019 •
edited
Loading

Reference Issues/PRs

Partially addresses #9250

CC @NicolasHug @adrinjalali

@NicolasHug NicolasHug mentioned this pull request Oct 21, 2019
Closed
This was referenced Oct 21, 2019
Merged
Merged
Merged
Merged
@thomasjpfan thomasjpfan changed the title [MRG] Makes submodules in semi_supervised private [MRG] Make modules private in semi_supervised Oct 21, 2019
qinhanmin2014
qinhanmin2014 approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge one PR and there will be conflicts in others :)

@qinhanmin2014 qinhanmin2014 merged commit e7de9b4 into scikit-learn:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

@qinhanmin2014 qinhanmin2014 qinhanmin2014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasjpfan @NicolasHug @qinhanmin2014