Skip to content

[MRG] Update What's new for 0.22.2.x #16610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jeremiedbb
Copy link
Member

Waiting for decision in #16609 regarding version number

@jnothman
Copy link
Member

jnothman commented Mar 2, 2020 via email

@jeremiedbb
Copy link
Member Author

I wrote that in #16609 where it might have more visibility

@jeremiedbb
Copy link
Member Author

@adrinjalali I changed the date and version of the what's new as we discussed.
@jnothman Are you ok with this ?

@jeremiedbb jeremiedbb added this to the 0.22.2 milestone Mar 2, 2020
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jeremiedbb

@jeremiedbb jeremiedbb changed the title [WIP] Update What's new for 0.22.2.x [MRG] Update What's new for 0.22.2.x Mar 2, 2020
@jeremiedbb
Copy link
Member Author

@adrinjalali since nobody complained I assume we can go for 0.22.2.post1. Let's merge this ?

@adrinjalali
Copy link
Member

I'll give it another hour for the NYC folks to wake up, I'd say no need to rush :)

@jnothman
Copy link
Member

jnothman commented Mar 2, 2020 via email

@adrinjalali
Copy link
Member

then for people who do a pip freeze for their requirements, it'll depend on whether they have the sdist installed or not. It'll be a bit inconsistent. Not sure how much it matters though.

@jeremiedbb
Copy link
Member Author

jeremiedbb commented Mar 2, 2020

Can we do post1 just for the sdist?

Do you mean leaving the 0.22.2 as is on pypi and make a new release with only a sdist ?

@ogrisel
Copy link
Member

ogrisel commented Mar 3, 2020

Do you mean leaving the 0.22.2 as is on pypi and make a new release with only a sdist ?

I am not sure this is a good idea. I think pip install --upgrade scikit-learn will try to upload everyone to 0.22.2.post1 even if you already have 0.22.2 installed which means that it will fail for people who do not have a compiler installed.

We have to re-release everything.

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a suggestion:

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a minor link mistake, I pushed directly.

@jeremiedbb jeremiedbb merged commit e6e5811 into scikit-learn:master Mar 3, 2020
jeremiedbb added a commit to jeremiedbb/scikit-learn that referenced this pull request Mar 3, 2020
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants