-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
[MRG] Update What's new for 0.22.2.x #16610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Update What's new for 0.22.2.x #16610
Conversation
Can you summarise what failed for those of us that have lacked time to see?
|
I wrote that in #16609 where it might have more visibility |
@adrinjalali I changed the date and version of the what's new as we discussed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jeremiedbb
@adrinjalali since nobody complained I assume we can go for 0.22.2.post1. Let's merge this ? |
I'll give it another hour for the NYC folks to wake up, I'd say no need to rush :) |
Can we do post1 just for the sdist?
|
then for people who do a |
Do you mean leaving the 0.22.2 as is on pypi and make a new release with only a sdist ? |
I am not sure this is a good idea. I think We have to re-release everything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just a suggestion:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a minor link mistake, I pushed directly.
Waiting for decision in #16609 regarding version number