[MRG] DOC kwonly section in whatsnew #17059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
approved these changes
Apr 27, 2020
doc/whats_new/v0.23.rst
Outdated
| arguments (i.e. using the `param=value` syntax) instead of positional. To | ||
| ease the transition, a `FutureWarning` is raised if a keyword-only parameter | ||
| is used as positional. In version 0.25, these parameters will be strictly | ||
| keyword-only, and a syntax error will be raised. |
There was a problem hiding this comment.
Oddly it's a TypeError:
In [1]: def f(a, *, b):
...: pass
...:
In [2]: f(1, 3)
---------------------------------------------------------------------------
TypeError Traceback (most recent call last)
<ipython-input-2-f0d8c2b0eb56> in <module>
----> 1 f(1, 3)
TypeError: f() takes 1 positional argument but 2 were given|
pinging #17010 just to have a list on that issue. |
What deprecations are you referring to? |
thomasjpfan
approved these changes
Apr 27, 2020
I think we have 5 other deprecations of some input params and attributes in this changelog, I meant to put them all together, but no big feelings there. |
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort of related to #17057
Addresses #17015 (comment)
CC @adrinjalali @thomasjpfan @rth @cmarmo