-
-
Notifications
You must be signed in to change notification settings - Fork 26.2k
REL backport fixes for 0.23.2 #18068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`sample_weight` should not be normalized in KMeans. The weight magnitude should have an influence on the `inertia_`, larger the weights, larger should be the inertia.
…t-learn#15730) Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com> Co-authored-by: Chiara Marmo <cmarmo@users.noreply.github.com> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
…scikit-learn#17433) * Make partial_fit ignore n_iter. * Revert whiteline. * Fix self.iter_offset. * Add test on iter_offset_ * Add what's new entry * Apply thomasjpfan suggestions.
…f the sum (scikit-learn#17694) Co-authored-by: Markus Rempfler <markus.rempfler@tum.de> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
…17812) Co-authored-by: Bruno Charron <bruno@charron.email>
Co-authored-by: Allan <allanbutler9@gmail.com> Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
…arn#17670) Co-authored-by: Loïc Estève <loic.esteve@ymail.com> Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
Co-authored-by: Joel Nothman <joel.nothman@gmail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
The wheel building infra is happy with this branch: MacPython/scikit-learn-wheels#63 |
ogrisel
approved these changes
Aug 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a manual pass to check that the list of commits in this PR is consistent with the changelog in the circle ci doc artifact.
jayzed82
pushed a commit
to jayzed82/scikit-learn
that referenced
this pull request
Oct 22, 2020
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com> Co-authored-by: Lucy Liu <jliu176@gmail.com> Co-authored-by: Kevin Markham <justmarkham@users.noreply.github.com> Co-authored-by: Juan Carlos Alfaro Jiménez <JuanCarlos.Alfaro@uclm.es> Co-authored-by: Forrest Koch <forrest.c.koch@gmail.com> Co-authored-by: Chiara Marmo <cmarmo@users.noreply.github.com> Co-authored-by: Swier <swierh@users.noreply.github.com> Co-authored-by: t-kusanagi2 <61999178+t-kusanagi2@users.noreply.github.com> Co-authored-by: Markus Rempfler <markus.rempfler@tum.de> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Bruno Charron <bcharron@gmx.com> Co-authored-by: Bruno Charron <bruno@charron.email> Co-authored-by: amy12xx <meezamanda@yahoo.com> Co-authored-by: Allan <allanbutler9@gmail.com> Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com> Co-authored-by: Hirofumi Suzuki <hs-nazuna@users.noreply.github.com> Co-authored-by: Loïc Estève <loic.esteve@ymail.com> Co-authored-by: Joel Nothman <joel.nothman@gmail.com> Co-authored-by: Charles Patel <charlespatel07@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17920.