Skip to content

Conversation

glemaitre
Copy link
Member

@glemaitre glemaitre commented Aug 3, 2020

Closes #17920.

@glemaitre glemaitre marked this pull request as draft August 3, 2020 07:44
jeremiedbb and others added 3 commits August 3, 2020 09:58
`sample_weight` should not be normalized in KMeans. The weight magnitude
should have an influence on the `inertia_`, larger the weights, larger should be
the inertia.
@ogrisel ogrisel added this to the 0.23.2 milestone Aug 3, 2020
glemaitre and others added 12 commits August 3, 2020 10:39
…t-learn#15730)

Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Co-authored-by: Chiara Marmo <cmarmo@users.noreply.github.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
…scikit-learn#17433)

* Make partial_fit ignore n_iter.

* Revert whiteline.

* Fix self.iter_offset.

* Add test on iter_offset_

* Add what's new entry

* Apply thomasjpfan suggestions.
…f the sum (scikit-learn#17694)

Co-authored-by: Markus Rempfler <markus.rempfler@tum.de>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Allan <allanbutler9@gmail.com>
Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
glemaitre and others added 3 commits August 3, 2020 11:53
…arn#17670)

Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
@ogrisel
Copy link
Member

ogrisel commented Aug 3, 2020

The wheel building infra is happy with this branch: MacPython/scikit-learn-wheels#63

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a manual pass to check that the list of commits in this PR is consistent with the changelog in the circle ci doc artifact.

@ogrisel ogrisel marked this pull request as ready for review August 4, 2020 09:08
@ogrisel ogrisel merged commit 947f542 into scikit-learn:0.23.X Aug 4, 2020
jayzed82 pushed a commit to jayzed82/scikit-learn that referenced this pull request Oct 22, 2020
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Co-authored-by: Lucy Liu <jliu176@gmail.com>
Co-authored-by: Kevin Markham <justmarkham@users.noreply.github.com>
Co-authored-by: Juan Carlos Alfaro Jiménez <JuanCarlos.Alfaro@uclm.es>
Co-authored-by: Forrest Koch <forrest.c.koch@gmail.com>
Co-authored-by: Chiara Marmo <cmarmo@users.noreply.github.com>
Co-authored-by: Swier <swierh@users.noreply.github.com>
Co-authored-by: t-kusanagi2 <61999178+t-kusanagi2@users.noreply.github.com>
Co-authored-by: Markus Rempfler <markus.rempfler@tum.de>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Bruno Charron <bcharron@gmx.com>
Co-authored-by: Bruno Charron <bruno@charron.email>
Co-authored-by: amy12xx <meezamanda@yahoo.com>
Co-authored-by: Allan <allanbutler9@gmail.com>
Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
Co-authored-by: Hirofumi Suzuki <hs-nazuna@users.noreply.github.com>
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Co-authored-by: Joel Nothman <joel.nothman@gmail.com>
Co-authored-by: Charles Patel <charlespatel07@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.