DOC improve n_jobs docs in CalibratedClassifierCV #18633
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
|
Thanks for review @adrinjalali |
adrinjalali
approved these changes
Oct 29, 2020
Looks like the documentation was already updated on master.
|
yep, this seems fixed on master already O_o. |
|
Sorry, it was probably concurrently fixed in #17856 which refactored the class and improved the docs significantly for this estimator. |
|
Only glad to see improvements to the codebase, thanks for your time gents! |
|
Hope you sick around after October, always nice to see good new contributors! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses part of #14228
What does this implement/fix? Explain your changes.
Updated docs to reflect meaning and usage of
n_jobsinCalibratedClassifierCVAny other comments?
#14228 is opened to improve / clarify the docs for
n_jobsin the sklearn code base. This PR focuses is tailored to addresssklearn/calibration.py, where the only function that containsn_jobsisCalibratedClassifierCV.