-
-
Notifications
You must be signed in to change notification settings - Fork 26k
[MRG] CI fix some nightly job failures #18711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank for working on this fix. Here is a general comment:
The rest of failures are related with #17707 (comment). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There is also the following deprecation warning in
|
Good catch @ogrisel 😄. I will have a look to the rest of failures to see if there is any |
Still one missing failure in
|
Another two in
|
@thomasjpfan I think this is already a net improvement. Shall we merge and open new PRs for fixing remaining failures? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup I agree. Let's merge this and work on the rest in other PRs.
@alfaro96: Do you know if the |
Sorry for the noise. It looks like #19101 is the patch I was looking for. |
What does this implement/fix? Explain your changes.
This PR fixes the nightly job failures. In particular:
NumPy
aliases by built-in types.floating
values tointeger
.