Skip to content

[MRG] CI fix some nightly job failures #18711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 12, 2020

Conversation

alfaro96
Copy link
Member

@alfaro96 alfaro96 commented Oct 30, 2020

What does this implement/fix? Explain your changes.

This PR fixes the nightly job failures. In particular:

  • Replacements of NumPy aliases by built-in types.
  • Explicit casting of floating values to integer.

@alfaro96 alfaro96 changed the title CI Fix Travis CRON job failures CI Fix nightly job failures Oct 30, 2020
@alfaro96 alfaro96 changed the title CI Fix nightly job failures [WIP] CI Fix nightly job failures Oct 30, 2020
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for working on this fix. Here is a general comment:

@alfaro96 alfaro96 changed the title [WIP] CI Fix nightly job failures [MRG] CI Fix nightly job failures Oct 30, 2020
@alfaro96
Copy link
Member Author

The rest of failures are related with #17707 (comment).

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ogrisel
Copy link
Member

ogrisel commented Nov 2, 2020

The rest of failures are related with #17707 (comment).

There is also the following deprecation warning in test_pairwise_parallel[float64-array-pairwise_distances-wminkowski-kwds1]:

DeprecationWarning: scipy.distance.wminkowski is deprecated and will be removed in SciPy 1.8.0, use scipy.distance.minkowski instead.

@alfaro96
Copy link
Member Author

alfaro96 commented Nov 2, 2020

The rest of failures are related with #17707 (comment).

There is also the following deprecation warning in test_pairwise_parallel[float64-array-pairwise_distances-wminkowski-kwds1]:

DeprecationWarning: scipy.distance.wminkowski is deprecated and will be removed in SciPy 1.8.0, use scipy.distance.minkowski instead.

Good catch @ogrisel 😄.

I will have a look to the rest of failures to see if there is any DeprecationWarning missing.

@alfaro96
Copy link
Member Author

alfaro96 commented Nov 5, 2020

Still one missing failure in test_exactly_zero_info_score:

E               AssertionError: assert 2.2207031250001146 == 0.0 ± 1.0e-12
E                +  where 2.2207031250001146 = adjusted_mutual_info_score(array([1, 1, 1, ..., 1, 1, 1]), array([   0,    1,    2, ..., 9997, 9998, 9999]), 'min')
E                +  and   0.0 ± 1.0e-12 = <function approx at 0x7f579ae87680>(0.0)
E                +    where <function approx at 0x7f579ae87680> = pytest.approx

@alfaro96
Copy link
Member Author

alfaro96 commented Nov 5, 2020

Another two in test_not_symmetric_metric[precision_recall_curve] and test_binary_sample_weight_invariance[precision_recall_curve]:

E       ValueError: cannot convert float NaN to integer

@ogrisel ogrisel changed the title [MRG] CI Fix nightly job failures [MRG] CI fix some nightly job failures Nov 12, 2020
@ogrisel
Copy link
Member

ogrisel commented Nov 12, 2020

@thomasjpfan I think this is already a net improvement. Shall we merge and open new PRs for fixing remaining failures?

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup I agree. Let's merge this and work on the rest in other PRs.

@thomasjpfan thomasjpfan merged commit 5a8bbf0 into scikit-learn:master Nov 12, 2020
@rmcgibbo
Copy link
Contributor

rmcgibbo commented Feb 2, 2021

@alfaro96: Do you know if the test_not_symmetric_metric[precision_recall_curve] and test_binary_sample_weight_invariance[precision_recall_curve] failures you noted above have been fixed on master? I'm seeing the same failures with 0.24.1 when running with numpy 1.20.

@rmcgibbo
Copy link
Contributor

rmcgibbo commented Feb 3, 2021

Sorry for the noise. It looks like #19101 is the patch I was looking for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants