Skip to content

Improve multiclass calibration example #18729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Improve multiclass calibration example #18729

wants to merge 1 commit into from

Conversation

ogrisel
Copy link
Member

@ogrisel ogrisel commented Nov 2, 2020 •
edited
Loading

This PR improves the multiclass calibration example to make it easier to follow:

  • Change the titles of the figures to make them more descriptive and accurate;
  • Use notebook cells to split the examples in smaller code snippets that are easier to digest (with better inline comments);
  • Use a larger test set to get more arrows on the first figure.

@ogrisel ogrisel mentioned this pull request Nov 2, 2020
Merged
@ogrisel
Copy link
Member Author

ogrisel commented Nov 2, 2020

Let's wait for #18731 to be merged first and I will rebase on master.

glemaitre
glemaitre reviewed Nov 2, 2020
View reviewed changes
@ogrisel ogrisel force-pushed the multiclass-calibration-example branch from f2925e3 to 68746d2 Compare November 2, 2020 14:36
@ogrisel ogrisel requested a review from lucyleeow November 2, 2020 14:37
@ogrisel
Copy link
Member Author

ogrisel commented Nov 3, 2020

@lucyleeow has some further improvements in mind on top of this. She will open a new PR and we will close this one then.

@lucyleeow lucyleeow mentioned this pull request Nov 5, 2020
Merged
@lucyleeow lucyleeow added Superseded PR has been replace by a newer PR and removed Waiting for Reviewer labels Nov 5, 2020
@ogrisel ogrisel closed this Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre left review comments

@lucyleeow lucyleeow Awaiting requested review from lucyleeow

Assignees
No one assigned
Labels
Documentation Superseded PR has been replace by a newer PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ogrisel @glemaitre @lucyleeow