-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
FIX Trigger CD build on master branch #18774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should trigger a build on push to release branches (regardless of whether the [cd build] commit trigger is present) and on PRs and push to master branch only if the [cd build] commit trigger is found.
I think this should be simplified further:
Let's try this. |
Now, it has been triggered 😉. Thank you @ogrisel for bearing me! |
The additional jobs make reading CI status a bit harder. There are now 25 CI tasks on master. Another alternative is to trigger this manually (via Github UI) prior to a release on some test branch and then run it on releases (see e.g. scikit-learn-contrib/scikit-learn-extra#74). I don't think we would care much about wheels CI, short of the few weeks before the release, and those CI statuses even if they are skipped would just create noise for most contributors. |
+1 of using the I will open a PR ASAP and we may evaluate there this proposal. |
What does this implement/fix? Explain your changes.
This should trigger a build on push to release branches (regardless of whether the
[cd build]
commit trigger is present) and on PRs and push to master branch only if the[cd build]
commit trigger is found.Quick review @ogrisel @thomasjpfan?