-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
CI Add workflow_dispatch event to manually trigger wheel builder #18801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Add workflow_dispatch event to manually trigger wheel builder #18801
Conversation
I have been able to run the Note that the |
Is there a way to trigger |
Yes, you can trigger on a branch from the forked repository. Indeed, I have been able to trigger the |
Yes, I can see how a contributor can trigger the workflow on their fork. How does a reviewer trigger the workflow when they are reviewing a PR? |
What do you about having a |
The |
I think the workflow of manually triggering would be:
|
Sorry @thomasjpfan, I misunderstood you 😞. Nevertheless, I think that I get your point now.
Alternatively, we could go to the
Yes, a maintainer should manually trigger the
Yes if it is related with the PR itself (and not with external issues). Going back to your comment in #18801 (comment), the question is how a reviewer (in this case, maintainer with write access) could trigger the |
It's okay! These things happen! I will do better with structuring my questions. :)
Yes this was the original question. If there was a way, I would be +1 on this PR. |
I have not found a way to allow reviewers (maintainers with write access) to trigger the Maybe @rth could help us. |
I would be in favor of re-introducing the |
Yes, I suggested this, but it's true that this use case might be problematic. It's probably possible to trigger it from upstream branches, but that's not the worflow we use. Sorry ) |
fa443f1
to
5e9e85d
Compare
Easy review @ogrisel and @thomasjpfan? In the end, I have only included the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the screenshot @thomasjpfan. I guess it does not hurt and it can spare a bit of commit noise.
LGTM.
Hum I should have edited the commit message to reflect what this PR actually does... |
Reference Issues/PRs
See #18774 (comment).
What does this implement/fix? Explain your changes.
This PR adds the
workflow_dispatch
event so that we can manually trigger theWheel builder
workflow when needed. Thus, I think that we do not need the[cd build]
commit trigger anymore.CC @rth, @ogrisel and @thomasjpfan.