Skip to content

MNT Parallel platforms for cibuildwheel [cd build] #18818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 12, 2020
Merged

MNT Parallel platforms for cibuildwheel [cd build] #18818

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4eb7469
Parallel platforms for cibuildwheel [cd build]
ogrisel Nov 12, 2020
dfd5464
Typo [cd build]
ogrisel Nov 12, 2020
0180fc6
Expand matrix [cd build]
ogrisel Nov 12, 2020
824b845
Explicitly define bitness matrix variable
ogrisel Nov 12, 2020
0209aba
Better name [cd build]
ogrisel Nov 12, 2020
0e1fe43
Another try [cd build]
ogrisel Nov 12, 2020
7f532f2
Typo in build name
ogrisel Nov 12, 2020
97b5149
Debug [cd build]
ogrisel Nov 12, 2020
8140538
Move bitness first in the matrix def [cd build]
ogrisel Nov 12, 2020
84eacb4
Fix typo, restore order [cd build]
ogrisel Nov 12, 2020
867fdcc
Cosmit [ci skip]
ogrisel Nov 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions .github/workflows/wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:

# Build the wheels for Linux, Windows and macOS for Python 3.6 and newer
build_wheels:
name: Build wheels on ${{ matrix.os }} for Python ${{ matrix.python }}
name: Build wheel for cp${{ matrix.python }}-${{ matrix.platform_id }}
runs-on: ${{ matrix.os }}
needs: check_build_trigger
if: needs.check_build_trigger.outputs.build
Expand All @@ -47,6 +47,27 @@ jobs:
matrix:
os: [windows-latest, ubuntu-latest, macos-latest]
python: [36, 37, 38, 39]
bitness: [32, 64]
include:
# Run 32 and 64 bit version in parallel for Linux and Windows
- os: windows-latest
bitness: 64
platform_id: win_amd64
- os: windows-latest
bitness: 32
platform_id: win32
- os: ubuntu-latest
bitness: 64
platform_id: manylinux_x86_64
- os: ubuntu-latest
bitness: 32
platform_id: manylinux_i686
- os: macos-latest
bitness: 64
platform_id: macosx_x86_64
exclude:
- os: macos-latest
bitness: 32

steps:
- name: Checkout scikit-learn
Expand All @@ -59,7 +80,7 @@ jobs:
env:
# Set the directory where the wheel is unpacked
CIBW_ENVIRONMENT: "WHEEL_DIRNAME=scikit_learn-$SCIKIT_LEARN_VERSION"
CIBW_BUILD: cp${{ matrix.python }}-*
CIBW_BUILD: cp${{ matrix.python }}-${{ matrix.platform_id }}
CIBW_TEST_REQUIRES: pytest pandas threadpoolctl
# Test that there are no links to system libraries
CIBW_TEST_COMMAND: pytest --pyargs sklearn &&
Expand Down