Skip to content

DOC Add translation section in related projects #19001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 26, 2021

Conversation

cmarmo
Copy link
Contributor

@cmarmo cmarmo commented Dec 14, 2020

Reference Issues/PRs

Closes #18984.
See also #18946 and #13400

What does this implement/fix? Explain your changes.

This pull request adds a link to available community translations of the scikit-learn documentation to the related projects page

Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmarmo and others added 2 commits December 14, 2020 17:13
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
NicolasHug
NicolasHug previously approved these changes Dec 15, 2020
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cmarmo, LGTM

Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
@NicolasHug NicolasHug dismissed their stale review December 15, 2020 14:35

Initially approved thinking comments would be easily addressed. Was wrong.

Base automatically changed from master to main January 22, 2021 10:53
@jeremiedbb
Copy link
Member

jeremiedbb commented Jan 26, 2021

@cmarmo you need to merge 'main' for the CI to run properly

Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I like this new version

@NicolasHug NicolasHug changed the title DOC Add link to community translations in the related project page. DOC Add translation section in related projects Jan 26, 2021
@NicolasHug NicolasHug merged commit 60fb637 into scikit-learn:main Jan 26, 2021
@glemaitre glemaitre mentioned this pull request Apr 22, 2021
12 tasks
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Apr 22, 2021
@cmarmo cmarmo deleted the translations branch July 11, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC Add link to translated documentations in the website
4 participants