Skip to content

ENH Adds feature_names_in_ to pipeline and multiclass #20780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 25, 2021

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

Continues #18010

What does this implement/fix? Explain your changes.

Adds feature_names_in_ into pipeline and multiclass.

@thomasjpfan thomasjpfan marked this pull request as draft August 20, 2021 02:18
@thomasjpfan thomasjpfan marked this pull request as ready for review August 20, 2021 02:19
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a missing test for the multiclass case.

Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -269,6 +269,12 @@ class OneVsRestClassifier(

.. versionadded:: 0.24

feature_names_in_ : ndarray of shape (`n_features_in_`,)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

n_features_in_ without ticks? See #20818 (comment).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without the ticks sphinx will give a warning: " WARNING: Unknown target name: "n_features_in"." because rst is considering it a Hyperlink Target

@ogrisel ogrisel merged commit 61653d3 into scikit-learn:main Aug 25, 2021
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
…0780)

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants