-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
ENH Adds feature_names_in_ to pipeline and multiclass #20780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a missing test for the multiclass case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -269,6 +269,12 @@ class OneVsRestClassifier( | |||
|
|||
.. versionadded:: 0.24 | |||
|
|||
feature_names_in_ : ndarray of shape (`n_features_in_`,) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
n_features_in_
without ticks? See #20818 (comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without the ticks sphinx will give a warning: " WARNING: Unknown target name: "n_features_in"." because rst is considering it a Hyperlink Target
…0780) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Reference Issues/PRs
Continues #18010
What does this implement/fix? Explain your changes.
Adds
feature_names_in_
intopipeline
andmulticlass
.