MNT bumb version number to 1.1 #20945
Conversation
|
@glemaitre @rth maybe? |
| -------------------- | ||
|
|
||
| Version 1.1.0 of scikit-learn requires python 3.7+, numpy 1.14.6+ and | ||
| scipy 1.1.0+. Optional minimal dependency is matplotlib 2.2.2+. |
There was a problem hiding this comment.
do we only state matplotlib or pandas and co. to be able to run the examples?
There was a problem hiding this comment.
Technically all those are optional dependencies, so it's unclear where we put the limit. I'm fine with the current version and also fine with adding pandas.
There was a problem hiding this comment.
I also thought about that, but as far as it goes for the library, and not the examples, we only consume pandas, whereas we actually use matplotlib. So I figured I'm happy with having matplotlib here but not pandas. Once we give pandas as output, then we'd need to have it here.
| -------------------- | ||
|
|
||
| Version 1.1.0 of scikit-learn requires python 3.7+, numpy 1.14.6+ and | ||
| scipy 1.1.0+. Optional minimal dependency is matplotlib 2.2.2+. |
There was a problem hiding this comment.
Technically all those are optional dependencies, so it's unclear where we put the limit. I'm fine with the current version and also fine with adding pandas.
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
|
Merging with two approvals and green tests |
* MNT bumb version number * add whats new to toc tree * Update doc/whats_new/v1.1.rst Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Bumps the version number in
mainto 1.1, and adds a new what's new file.