TST solve issues in PyPy #20978
TST solve issues in PyPy #20978
Conversation
|
tagging #20965 |
|
not sure why codecov complains, but PyPy seems happy? |
|
Yes. We can merge. Just have to remove my |
.circleci/config.yml
Outdated
| only: | ||
| - 0.20.X | ||
| requires: | ||
| - lint |
There was a problem hiding this comment.
Do we really want to run the pypy3 job on all pull requests? Or keep it disabled for the PR and only run for the cron scheduled nightly builds?
There was a problem hiding this comment.
Furthermore, running the pypy3 job as part of a workflow namedbuild-doc-and-deploy is really counter intuitive.
There was a problem hiding this comment.
I think we should remove the pypy3 job from the build-doc-and-deploy workflow.
There was a problem hiding this comment.
Fine with me. At least it was to check that everything worked in this PR.
There was a problem hiding this comment.
I'm happy not to have it in build-doc-and-deploy, but this bites us almost every time at a release, should we not have at least one PyPy test on PRs?
|
Ok, gonna merge this, we can address the CI on prs later. |
* TST fix brittle test in pypy for error message * iter * Update test_sgd.py * Update test_sgd.py * remove pypy3 in PRs
* TST fix brittle test in pypy for error message * iter * Update test_sgd.py * Update test_sgd.py * remove pypy3 in PRs
* TST fix brittle test in pypy for error message * iter * Update test_sgd.py * Update test_sgd.py * remove pypy3 in PRs
No description provided.