Release 1.0 cherry-picks #21090
Merged
Release 1.0 cherry-picks #21090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* MAINT missing what's new entry for PR-19401 * Consolidate sklearn.feature_extraction entries + fix refs
…arn#20973) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
…learn#20979) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: Alexandre Gramfort <alexandre.gramfort@inria.fr>
…cikit-learn#20982) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
…0985) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
…0986) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
…earn#20988) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Johnathan Alexander <jalexander86@gatech.edu>
…t-learn#21013) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
…it-learn#21014) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
…learn#21015) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
…arn#21030) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
…ydoc validation (scikit-learn#21037) Co-authored-by: frellwan <frellwan@hotmail.com>
…scikit-learn#20728) Co-authored-by: Reshama Shaikh <reshama.stat@gmail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
…arn#21072) Co-authored-by: frellwan <frellwan@hotmail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
…kit-learn#21063) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
…rn#21077) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
…21057) Co-authored-by: Johnathan Alexander <jalexander86@gatech.edu> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Tom Dupré la Tour <tom.dupre-la-tour@m4x.org> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com> Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
|
I thought PyPy is supposed to be faster than cpython, why is it then always the last one to finish on our CI? @rth any idea? |
|
Can I please have at least a second pair of eyes on this before I merge? @lorentzenchr maybe? |
|
@adrinjalali Some of the contributors of the cherry-picks are maybe missing under whatsnew. Examples are
I couldn't find other tagged PRs. All PRs and issues of milestone 1.0 are addressed. So I think, apart from the missing contributors' names, we're good to go. |
lorentzenchr
approved these changes
Sep 22, 2021
|
#21111 is merged, we can now add it to this PR to finish up the release. |
|
#21096 fixes a typo in the 1.0 release highlights. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the cherry pick list for the release. I've included the DOC improvements.
There's only #21080 that we're still waiting for, and will add to this list once merged. I'd like to ideally merge this today.
THIS SHOULD NOT BE SQUASHED
Here's the list of picks:
cc @scikit-learn/core-devs