-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
DOC Ensures that LocallyLinearEmbedding passes numpydoc validation #21273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
glemaitre
merged 8 commits into
scikit-learn:main
from
baam25simo:LocallyLinearEmbedding-numpydoc-validation
Oct 21, 2021
Merged
DOC Ensures that LocallyLinearEmbedding passes numpydoc validation #21273
glemaitre
merged 8 commits into
scikit-learn:main
from
baam25simo:LocallyLinearEmbedding-numpydoc-validation
Oct 21, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
approved these changes
Oct 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I resolve the conflicts and took the opportunity to itemize the solver choices. Let's wait for the documentation CI to finish before merging.
All good. Thanks @baam25simo |
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 23, 2021
…cikit-learn#21273) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre
added a commit
that referenced
this pull request
Oct 25, 2021
…21273) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
…cikit-learn#21273) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #20308
What does this implement/fix? Explain your changes.
LocallyLinearEmbedding
removed fromDOCSTRING_IGNORE_LIST
in test_docstrings.pyLocallyLinearEmbedding.__init__
: "See Also" section added and minor fixes.LocallyLinearEmbedding.fit
:y
andreturn
descriptions added.LocallyLinearEmbedding.fit_transform
:return
description added.LocallyLinearEmbedding.transform
:X
andreturn
descriptions added.