Old test for pull request #21753
Closed
Old test for pull request #21753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Check that the type of the elements of input_features is string. If not raise a warning explaining that others problem could occur. - Cast input_features elements to string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes type problems for get_feature_names in OneHotEncoder
Hello, I have to work on this issue for a school project.
I propose to cast integer-columns to string-columns & put a warning to inform the user that it is possible that others errors will happen later.
I don't think we should force the user to put strings because some of the cases stated above are common (like csv files without headers). We can't change all the consistency problems of Pandas.