FIX Only raise feature name warning with mixed types and strings #22410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
approved these changes
Feb 8, 2022
doc/whats_new/v1.1.rst
Outdated
Comment on lines
49
to
50
| no longer warns when passed into an Estimator. These non-string columns | ||
| will be supported in 1.3. Note that `feature_names_in_` will continue to |
There was a problem hiding this comment.
Updated PR to clarify what supported means:
Estimators will continue to ignore the column names in DataFrames with non-string columns. For
feature_names_in_to be defined, columns must be all strings
ogrisel
approved these changes
Feb 8, 2022
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Feb 9, 2022
ilivans
pushed a commit
to ilivans/scikit-learn
that referenced
this pull request
Feb 10, 2022
thomasjpfan
added a commit
to thomasjpfan/scikit-learn
that referenced
this pull request
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Closes #22399
What does this implement/fix? Explain your changes.
This PR adjusts the check to only raise a warning for feature names when there is a mixed dtype and a string is in it.
Any other comments?
I think this is more consistent with the @ogrisel's comment here: #18010 (comment)
CC @glemaitre