ENH Deprecate class_weight_ in regression/single class models in SVM module
#22898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed instation of `class_weight_ = np.empty(0)` in `BaseLibSVM` - Added deprecated properties for `class_weight_` and `n_support_` in `SVR`, `NuSVR`, and `OneClassSVM`.
thomasjpfan
reviewed
Mar 23, 2022
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
- Updated tests to use `n_support_[0]` directly - Added deprecated property to `SVR, NuSVR, OneClassSVM` - Removed partial `n_support_` deprecation in parent `BaseLibSVM` - Removed reliance on `n_support_` in `_validate_for_predict`
thomasjpfan
reviewed
Apr 27, 2022
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
…-learn into deprecate_in_svr
thomasjpfan
reviewed
Apr 29, 2022
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
thomasjpfan
reviewed
May 6, 2022
class_weight_ and n_support_ in regression/single class models in SVM moduleclass_weight_ in regression/single class models in SVM module
class_weight_ in regression/single class models in SVM moduleclass_weight_ in regression/single class models in SVM module
thomasjpfan
reviewed
May 22, 2022
thomasjpfan
approved these changes
May 24, 2022
ogrisel
approved these changes
May 24, 2022
There was a problem hiding this comment.
It took me time to get it but it looks correct and the tests pass without raising the warning when it should not be raised.
The trick to look at the _validate_targets method that is overridden in the classifier base class BaseSVC that defines the public class_weight_ only for classifiers.
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Jun 14, 2022
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Aug 29, 2022
ivannz
added a commit
to ivannz/scikit-learn
that referenced
this pull request
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #14788
What does this implement/fix? Explain your changes.
Began deprecation of some properties in svm module
class_weight_ = np.empty(0)inBaseLibSVM_class_weightinBaseLibSVMto serve as an intermediate for deprecation by avoiding direct calls toclass_weight_forSVR,NuSVR, andOneClassSVMAny other comments?