[WIP] TST use global_random_seed in sklearn/linear_model/tests/test_base.py #23464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto doc_ensemble_plot_adaboost_regression
…ings) is available
…nto doc_ensemble_plot_adaboost_regression
…ts, which fails on a few seeds now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: I forgot to check out a new branch xD disregard this until fixed
Reference Issues/PRs
Partially addresses #22827
What does this implement/fix? Explain your changes.
Added global_random_seed to
test_linear_regression_sample_weights- it fails on more than a few seeds. Did not address this yet.Any other comments?
While I work on fixing this, I am happy to receive comments and ideas on how to handle this file in general
sklearn/linear_model/tests/test_base.py- should we refactor and fix all the tests in one PR or tackle one test after the other in separate PRs?E.g. creating a thread for the file and then I will tackle test after test as a Task-List?