Skip to content

MNT Fixes lgtm config for Cpp #23493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

thomasjpfan
Copy link
Member

Reference Issues/PRs

Related to #23492

What does this implement/fix? Explain your changes.

#23492 failed on lgtm for cpp, because the NumPy is below the minimal support NumPy version.

Any other comments?

I do not know why this was not failing before.

@lorentzenchr
Copy link
Member

I was a bit quick to approve. The lgtm ci still fails with

[build-stderr] ImportError: Your installation of numpy 1.16.3 is out-of-date.
[build-stderr] scikit-learn requires numpy >= 1.17.3.

@alfaro96
Copy link
Member

alfaro96 commented May 31, 2022

I was a bit quick to approve. The lgtm ci still fails with

[build-stderr] ImportError: Your installation of numpy 1.16.3 is out-of-date.
[build-stderr] scikit-learn requires numpy >= 1.17.3.

I was also curious about that. I think that the one failing is from commit effdd6e of the main branch: https://lgtm.com/projects/g/scikit-learn/scikit-learn/logs/rev/pr-ad65350510e627f1dcd72af957303fbd0cf51341/lang:cpp/stage:Build%20main_effdd6e215c67f2ae8ed1e378ea1661e936059a4

@alfaro96
Copy link
Member

alfaro96 commented May 31, 2022

@thomasjpfan
Copy link
Member Author

I wonder if we should turn off the C/C++ one, we have not gotten much results from it:

https://lgtm.com/projects/g/scikit-learn/scikit-learn/alerts/?mode=list&lang=cpp

https://lgtm.com/projects/g/scikit-learn/scikit-learn/history/

@thomasjpfan
Copy link
Member Author

The status report for lgtm is showing the error from main, specifically this commit: effdd6e

I think this PR is good for merging.

@lorentzenchr lorentzenchr merged commit 1815cfc into scikit-learn:main Jun 3, 2022
ogrisel pushed a commit to ogrisel/scikit-learn that referenced this pull request Jul 11, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 4, 2022
glemaitre pushed a commit that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants