-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
MNT Fixes lgtm config for Cpp #23493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I was a bit quick to approve. The lgtm ci still fails with
|
I was also curious about that. I think that the one failing is from commit |
In fact, the merge commit is building successfully: https://lgtm.com/projects/g/scikit-learn/scikit-learn/logs/rev/pr-ad65350510e627f1dcd72af957303fbd0cf51341/lang:cpp/stage:Build%20merge_8045c630e255e43accbbeb1a690608d120ca8f44. |
I wonder if we should turn off the C/C++ one, we have not gotten much results from it: https://lgtm.com/projects/g/scikit-learn/scikit-learn/alerts/?mode=list&lang=cpp https://lgtm.com/projects/g/scikit-learn/scikit-learn/history/ |
The status report for lgtm is showing the error from I think this PR is good for merging. |
Reference Issues/PRs
Related to #23492
What does this implement/fix? Explain your changes.
#23492 failed on lgtm for cpp, because the NumPy is below the minimal support NumPy version.
Any other comments?
I do not know why this was not failing before.