Skip to content

Conversation

madinak
Copy link
Contributor

@madinak madinak commented May 31, 2022

Reference Issues/PRs

Contributes to #21350

What does this implement/fix? Explain your changes.

Fixed numpydoc errorsin sklearn.metrics._ranking.roc_auc_score

Any other comments?

as a part of pyladies berlin hacknight

@madinak
Copy link
Contributor Author

madinak commented May 31, 2022

ping @adrinjalali

Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @madinak .

Other than the nit, LGTM.

@@ -471,6 +471,16 @@ class scores must correspond to the order of ``labels``,
Returns
-------
auc : float
Area Under the Curve.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Area Under the Curve.
Area Under the Curve score.

@adrinjalali
Copy link
Member

Thanks, will merge when green since it's a minor doc change.

@adrinjalali
Copy link
Member

There was a merge conflict due to the other PR, I've resolved it and will wait for the CI to finish.

@adrinjalali adrinjalali merged commit 3da9643 into scikit-learn:main Jun 1, 2022
ogrisel pushed a commit to ogrisel/scikit-learn that referenced this pull request Jul 11, 2022
…rn#23505)

* DOC Ensures that roc_auc_score passes numpydoc validation

* apply review

Co-authored-by: Madina Kasymova <madina.kasymova@dida.do>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 4, 2022
…rn#23505)

* DOC Ensures that roc_auc_score passes numpydoc validation

* apply review

Co-authored-by: Madina Kasymova <madina.kasymova@dida.do>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
glemaitre pushed a commit that referenced this pull request Aug 5, 2022
* DOC Ensures that roc_auc_score passes numpydoc validation

* apply review

Co-authored-by: Madina Kasymova <madina.kasymova@dida.do>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants