Skip to content

DOC fix add reference in Skewed Chi Squared Kernel to linkcheck ignore #23743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2022
Merged

DOC fix add reference in Skewed Chi Squared Kernel to linkcheck ignore #23743

merged 2 commits into from
Jun 24, 2022

Conversation

kanissh
Copy link
Contributor

@kanissh kanissh commented Jun 23, 2022

Added reference to researchgate to linkcheck ignore

Reference Issues/PRs

Issue: #23631

See also PR: #23713

What does this implement/fix? Explain your changes.

Added https://www.researchgate.net/publication/221114584_Random_Fourier_Approximations_for_Skewed_Multiplicative_Histogram_Kernels to linkcheck_ignore.

Any other comments?

Additional fix to the new link replaced by PR #23713. Due to researchgate links creating linkcheck error, the new link is put in linkcheck_ignore.

Added reference to researchgate to linkcheck ignore
@lesteve
Copy link
Member

lesteve commented Jun 24, 2022

linting is not happy, because the line you added is too long:

doc/conf.py:600:89: E501 line too long (131 > 88 characters)
    "[https://www.researchgate.net/publication/221114584_Random_Fourier_Approximations_for_Skewed_Multiplicative_Histogram_Kernels",](https://www.researchgate.net/publication/221114584_Random_Fourier_Approximations_for_Skewed_Multiplicative_Histogram_Kernels%22,)

Can you split the link on two or more lines as done for other links?

@lesteve
Copy link
Member

lesteve commented Jun 24, 2022

Merging, thanks a lot!

@lesteve lesteve merged commit a6e3486 into scikit-learn:main Jun 24, 2022
ogrisel pushed a commit to ogrisel/scikit-learn that referenced this pull request Jul 11, 2022
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants