Addresses #24085 - Gaussian mixture weights #24117
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto validate_spline_transformer
…nto validate_spectralembedding
|
Hey there @kasmith11, thanks for the PR! It looks like you may have branched off your Edit: It seems that branch is also based off of the branch you used for #24057. This is bringing in extra commits which shouldn't be included. Could you update this PR to only include the change to the problematic line? (It may be easier just to open a new PR) |
|
@Micky774 I created a new PR. Thanks! I'll go ahead and close this request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #24085
What does this implement/fix? Explain your changes.
Weights that were normalized using
n_samplesnow useweights_.sum()Any other comments?