CLN _hdbscan/_tree.pyx algorithms refactor
#26011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 5, 2023
|
@lmcinnes I wonder if you could take a look and offer your thoughts as well, to potentially help reviewers make their decisions with confidence. I tried to avoid altering any necessary logic and instead focus on reducing/simplifying conditions as far as possible. |
thomasjpfan
reviewed
Apr 6, 2023
Micky774
commented
Apr 11, 2023
| lambda_val = sorted_lambdas[idx] | ||
|
|
||
| if child == current_child: | ||
| min_lambda = min(min_lambda, lambda_val) |
There was a problem hiding this comment.
Note that child != current_child in this algorithm since each child is unique to a single parent and hence only appears once. I suspect the removal of this line also simplifies the algorithm enough to remove the need for sorting entirely.
|
LGTM There are probably a number of things that could also be simplified, but it is probably best to keep things as close to the earlier implementation as possible for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #24686
What does this implement/fix? Explain your changes.
Simplifies algorithms with reorganization of logic, removing/de-nesting extraneous
ifstatements, and pruning unnecessary variablesAny other comments?
This is the final PR in the long series of backend cleanup PRs :)
CC: @thomasjpfan @jjerphan
You two may be interested in taking a look