Skip to content

CLN BFS Style Improvement #26096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 5, 2023
Merged

Conversation

Micky774
Copy link
Contributor

@Micky774 Micky774 commented Apr 5, 2023

Reference Issues/PRs

Addresses #24686
Selected subset of #26011

What does this implement/fix? Explain your changes.

Makes stylistic improvements to bfs_from_cluster_tree

Any other comments?

These changes were extracted from #26011 to facilitate quick review

Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
@Micky774 Micky774 changed the title BFS style cleanup CLN BFS Style Improvement Apr 5, 2023
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Merging because this is a stylistic change.

@thomasjpfan thomasjpfan merged commit 7325d62 into scikit-learn:hdbscan Apr 5, 2023
@Micky774 Micky774 deleted the hdbscan_bfs branch April 5, 2023 16:15
Micky774 added a commit to Micky774/scikit-learn that referenced this pull request May 16, 2023
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants