ENH fix x- and y-axis limits and ratio in ROC and PR displays #26366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this what we want? I think we want to set aspect to 1, especially for PR curves (see https://gist.github.com/Charlie-XIAO/ecd5173fe0daa9c49f442153ef19e7d1). With your ratio I'm getting PR curve plots like this: 
|
glemaitre
approved these changes
Jun 15, 2023
glemaitre
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
I checked the rendering on the generated documentation and this is fine.
Ready for merging.
@ArturoAmorQ do you want to make a pass such that we merge this one?
glemaitre
approved these changes
Aug 21, 2023
I have my eyes on it! 👀 |
ArturoAmorQ
approved these changes
Aug 23, 2023
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
|
Merging thanks all. |
akaashpatelmns
pushed a commit
to akaashp2000/scikit-learn
that referenced
this pull request
Aug 25, 2023
…-learn#26366) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Aug 29, 2023
…-learn#26366) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
…-learn#26366) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #25929
We set the ratio to
1/ ax.get_data_ratio()to get square plotIt is related to point 3 as discussed in the issue #25929