Skip to content

MAINT Remove outdated fixes #26442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

jeremiedbb
Copy link
Member

These fixes were based on versions of scipy that we no longer support.

@jeremiedbb jeremiedbb added No Changelog Needed Quick Review For PRs that are quick to review labels May 26, 2023
@jeremiedbb
Copy link
Member Author

Although codecov is probably revealing a true lack of coverage, I would ignore it for this PR which only purpose is to remove outdated fixes. Adding more tests for the guilty module should be done in a separate PR.

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to GitHub, there is a merge conflict to resolve in this PR.

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels GOOD

@adrinjalali adrinjalali merged commit 9be4d8d into scikit-learn:main Jun 1, 2023
@adrinjalali
Copy link
Member

adrinjalali commented Jun 1, 2023

giphy-3756466156

manudarmi pushed a commit to primait/scikit-learn that referenced this pull request Jun 12, 2023
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Changelog Needed Quick Review For PRs that are quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants