FIX ravel prediction of PLSRegression when fitted on 1d y
#26602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betatim
reviewed
Jul 11, 2023
| Ypred = X @ self.coef_.T | ||
| return Ypred + self.intercept_ | ||
| Ypred = X @ self.coef_.T + self.intercept_ | ||
| return Ypred.ravel() if self._predict_1d else Ypred |
There was a problem hiding this comment.
nit: my personal taste/preference is to split this up into a if self._predict_1d: ... else: ... (so spread over four lines). I find it easier to read/spot that there is a if here compared to using the one liner. But others might have other tastes :-/
There was a problem hiding this comment.
In my opinion I think it is fine both ways.
betatim
approved these changes
Jul 11, 2023
OmarManzoor
reviewed
Jul 20, 2023
PLSRegression when fitted on 1d yPLSRegression when fitted on 1d y
|
@OmarManzoor Thanks for your review! I've resolved the issues you mentioned. |
OmarManzoor
reviewed
Jul 21, 2023
|
Sorry for the late reply @OmarManzoor, committed your suggestions now. |
OmarManzoor
approved these changes
Jul 24, 2023
punndcoder28
pushed a commit
to punndcoder28/scikit-learn
that referenced
this pull request
Jul 29, 2023
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 18, 2023
jeremiedbb
pushed a commit
that referenced
this pull request
Sep 20, 2023
|
The changelog entry of this PR seems to have accidentally been deleted in the recent restructuring. I think it needs to be added again. |
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes: #26549.
What does this implement/fix? Explain your changes.
This implements #26549 (comment) for
PLSRegression. Please let me know if the alternative (#26549 (comment)) is more desired, or if I should implement this for other multi-output regressors as well in this PR.