Skip to content

MNT clean up old scipy sparse.linalg.cg fallback code #26813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Jul 10, 2023

atol parameter exists since scipy 1.1 https://docs.scipy.org/doc/scipy-1.1.0/reference/generated/scipy.sparse.linalg.cg.html and our min supported version is scipy 1.5.

@lesteve lesteve added the Quick Review For PRs that are quick to review label Jul 10, 2023
@github-actions
Copy link

github-actions bot commented Jul 10, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: b38e8ee. Link to the linter CI: here

Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:linear_model Quick Review For PRs that are quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants