-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
DOC Add missing links to examples/impute #27053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
adrinjalali
merged 5 commits into
scikit-learn:main
from
MarcusFra:example_links_imputation
Sep 11, 2023
Merged
DOC Add missing links to examples/impute #27053
adrinjalali
merged 5 commits into
scikit-learn:main
from
MarcusFra:example_links_imputation
Sep 11, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
reviewed
Aug 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, please also add a link to this example from the docstrings of the imputer classes used in the example as well.
…t-learn into example_links_imputation
@adrinjalali I've added the examples to the docstrings of the imputer classes (both in the docstrings of the |
adrinjalali
approved these changes
Aug 24, 2023
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Sep 18, 2023
jeremiedbb
pushed a commit
that referenced
this pull request
Sep 20, 2023
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #26927. Added link to
plot_missing_values.py
twice in the user guide (doc/modules/impute.rst
). Please check if adding the links might be overwhelming.This PR covers both examples from examples/impute, namely
plot_missing_values.py
andplot_iterative_imputer_variants_comparison.py
. I can confirm that both examples are already included in the bottom sections of the respective API docs of theimpute
module where appropriate.