Skip to content

DOC Add missing links to examples/impute #27053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 11, 2023

Conversation

MarcusFra
Copy link
Contributor

Towards #26927. Added link to plot_missing_values.py twice in the user guide (doc/modules/impute.rst). Please check if adding the links might be overwhelming.

This PR covers both examples from examples/impute, namely plot_missing_values.py and plot_iterative_imputer_variants_comparison.py. I can confirm that both examples are already included in the bottom sections of the respective API docs of the impute module where appropriate.

@github-actions
Copy link

github-actions bot commented Aug 11, 2023

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 8a7a6a4. Link to the linter CI: here

Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please also add a link to this example from the docstrings of the imputer classes used in the example as well.

@MarcusFra
Copy link
Contributor Author

@adrinjalali I've added the examples to the docstrings of the imputer classes (both in the docstrings of the IterativeImputer class).

@adrinjalali adrinjalali changed the title DOC Add missing links to examples/impute (scikit-learn#26927) DOC Add missing links to examples/impute Sep 11, 2023
@adrinjalali adrinjalali merged commit b0da1b7 into scikit-learn:main Sep 11, 2023
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Sep 18, 2023
REDVM pushed a commit to REDVM/scikit-learn that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants