TST Test Array API-compatible metrics with sample_weight
#27335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we can ignore the partial coverage of the newly added conditions on the codecov report: It means that the case where the condition is |
ogrisel
approved these changes
Sep 11, 2023
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
|
Hey @betatim , not sure if you saw this one. :) This PR is addressing the suggestion here: #27137 (comment) |
|
Thanks for the ping, I had indeed missed this! Looking now |
|
Merged! |
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 31, 2023
…arn#27335) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
REDVM
pushed a commit
to REDVM/scikit-learn
that referenced
this pull request
Nov 16, 2023
…arn#27335) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
See comments in #27137
What does this implement/fix? Explain your changes.
As suggested in the review, this PR adds an additional test for all the Array API-compatible metrics that have a
sample_weightargument.cc @ogrisel @betatim