-
-
Notifications
You must be signed in to change notification settings - Fork 26.2k
TST Test Array API-compatible metrics with sample_weight
#27335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST Test Array API-compatible metrics with sample_weight
#27335
Conversation
I think we can ignore the partial coverage of the newly added conditions on the codecov report: It means that the case where the condition is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the follow-up. Here is a small suggestion for improving readability / intent, but otherwise LGTM!
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Hey @betatim , not sure if you saw this one. :) This PR is addressing the suggestion here: #27137 (comment) |
Thanks for the ping, I had indeed missed this! Looking now |
Merged! |
…arn#27335) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
…arn#27335) Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Reference Issues/PRs
See comments in #27137
What does this implement/fix? Explain your changes.
As suggested in the review, this PR adds an additional test for all the Array API-compatible metrics that have a
sample_weight
argument.cc @ogrisel @betatim