FIX Disable PairwiseDistanceReductions on the Euclidean CSR×CSR case #28235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
|
Thanks for tackling this @jjerphan. The CI report shows that some more tests need an update. Feel free to ping me again once the CI is green. |
|
I push a fix for the test with an additional comment. |
adrinjalali
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
It's a pity, but good as a hotfix. Thanks @jjerphan
LGTM if the tests pass
OmarManzoor
approved these changes
Jan 25, 2024
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Feb 10, 2024
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Feb 13, 2024
glemaitre
pushed a commit
that referenced
this pull request
Feb 13, 2024
suhaibmujahid
pushed a commit
to mozilla/bugbug
that referenced
this pull request
Feb 19, 2024
…3799) The fix was implemented in scikit-learn/scikit-learn#28235
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Hotfix for #28191.
What does this implement/fix? Explain your changes.
Any other comments?
cc @adrinjalali.