-
-
Notifications
You must be signed in to change notification settings - Fork 25.8k
DOC simplify the structure of about and testimonials #28270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC simplify the structure of about and testimonials #28270
Conversation
Otherwise the rest of the rendering is fine for me. |
Thanks for spotting that. I may remove the borders by styling that table, or I'm thinking about not using table but using a bootstrap-style grid instead, so that we do not force four logos in a row on small screens. I may not have time for this right now, but will come back in a day. |
Done @glemaitre. For the second table I tried to make the code as simple as possible, but it still kind of looks weird (not the rendering but the source code). Please let me know if it is acceptable. On my laptopOn my phone![]() ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'll let @glemaitre have another look and merge.
I think I'm going to close this one. With |
This PR is mainly intended to simplify the work in #28084 towards switching to
pydata-sphinx-theme
. I made special adjustments so that it can targetmain
without relying on the setup in #28132.This PR simplifies the structure of the
about
andtestimonials/testimonials
pages. In short, it does the following:.. raw:: html
blocks over and over again. More importantly, the class names are no longer distributed all over the document so it is easier to change class name or styles.testimonials/testimonials
) and 100px (forabout
).There are some other minor changes, such that if undesired, please feel free to let me know so that I can revert:
about
page, the reason being that two adjacent headings do not look that well (too much space in between) inpydata-sphinx-theme
.