Skip to content

DOC update funders about page and index #28417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

glemaitre
Copy link
Member

@glemaitre glemaitre commented Feb 13, 2024

Update the index and about pages to reflect the current project sponsors.

@glemaitre glemaitre added this to the 1.4.1 milestone Feb 13, 2024
@glemaitre glemaitre added the To backport PR merged in master that need a backport to a release branch defined based on the milestone. label Feb 13, 2024
Copy link

github-actions bot commented Feb 13, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: aec89e0. Link to the linter CI: here

@@ -1001,7 +1001,6 @@ table.docutils {
margin-bottom: 1rem;
line-height: 1rem;
max-width: 100%;
display: block;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This disallow centering the table (not a CSS expert). It does not have influence on the overflow-x that we fixed recently.

<https://scikit-learn.fondation-inria.fr/en/home/>`_ fund Arturo Amor,
François Goupil, Guillaume Lemaitre, Jérémie du Boisberranger, and Olivier Grisel.
<https://scikit-learn.fondation-inria.fr/en/home/>`_ help at maintaining and
improving the project through their financial support.

.. raw:: html

</div>

.. |chanel| image:: images/chanel.png
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I resized the following image to have about the visual aspects than the single sponsor later

@glemaitre
Copy link
Member Author

ping @ogrisel regarding the changes

Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

@adrinjalali
Copy link
Member

Gonna wait for @ogrisel to have a look

@ogrisel
Copy link
Member

ogrisel commented Feb 16, 2024

LGTM. I will merge and open a follow-up PR to backport to stable.

@ogrisel ogrisel merged commit 6cdff9f into scikit-learn:main Feb 16, 2024
ogrisel pushed a commit to ogrisel/scikit-learn that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation To backport PR merged in master that need a backport to a release branch defined based on the milestone.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants