Skip to content

Fix issue with Pytest 8.1 #28570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 4, 2024
Merged

Fix issue with Pytest 8.1 #28570

merged 6 commits into from
Mar 4, 2024

Conversation

adrinjalali
Copy link
Member

Copy link

github-actions bot commented Mar 4, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 529996b. Link to the linter CI: here

@adrinjalali
Copy link
Member Author

cc @lesteve @ogrisel

@lesteve
Copy link
Member

lesteve commented Mar 4, 2024

The sklearn/externals/conftest.py fix looks good.

Just to make sure, you have updated only the main-ci builds, right?

Since there is currently an issue in the doc build as you noted in #28569 (comment), maybe do not update the doc and doc-min-dependencies lock-files in this PR so this PR can be merged quicker?

@adrinjalali
Copy link
Member Author

The lock files of the doc build don't have much to do with the failure of the doc CI though. So I'm not sure if I follow.

@lesteve
Copy link
Member

lesteve commented Mar 4, 2024

I have pushed a commit with [doc build] to make sure that the full doc build is not more broken that main. If that is the case I am fine with merging the PR even with a red full doc build.

In other words, when we update a doc-related lock-file, we want to make sure the full doc build runs without issues, by adding [doc build] in the commit message. Right now we can not really do that since the full doc build is broken on main. I was originally suggesting not updating the doc-related lock-files so we avoid this issue.

Copy link
Member

@lesteve lesteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the doc builds fail for the same reason as in main, see build log, so I am fine merging this one.

@lesteve lesteve enabled auto-merge (squash) March 4, 2024 12:55
@lesteve
Copy link
Member

lesteve commented Mar 4, 2024

I have enabled auto-merge and pushed a commit to trigger CI again (without a full doc build so it should be green)

@lesteve lesteve disabled auto-merge March 4, 2024 12:59
@lesteve lesteve enabled auto-merge (squash) March 4, 2024 12:59
@lesteve lesteve merged commit 08b4714 into scikit-learn:main Mar 4, 2024
@adrinjalali adrinjalali deleted the pytest-8.1 branch March 4, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants