Skip to content

CI Update Pyodide to 0.25.1 #28770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 4, 2024
Merged

CI Update Pyodide to 0.25.1 #28770

merged 4 commits into from
Apr 4, 2024

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Apr 4, 2024

Pyodide build has been failing for a few days e.g. this build log

Similar issue was seen in numpy numpy/numpy#26164 and has been fixed in Pyodide 0.25.1.

Traceback:

Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.11.3/x64/lib/python3.11/site-packages/pyodide_build/pypabuild.py", line 71, in _runner
    env["BUILD_ENV_SCRIPTS_DIR"] = isolated_build_env._scripts_dir
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: '_DefaultIsolatedEnv' object has no attribute '_scripts_dir'

@lesteve lesteve added Quick Review For PRs that are quick to review and removed Build / CI labels Apr 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 71f115e. Link to the linter CI: here

@lesteve
Copy link
Member Author

lesteve commented Apr 4, 2024

One approval, the Pyodide build passed, there you go, merging my own PR 😅

@lesteve lesteve merged commit 6bf0ba5 into scikit-learn:main Apr 4, 2024
@lesteve lesteve deleted the pyodide-0.25.1 branch April 4, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
Quick Review For PRs that are quick to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lesteve @thomasjpfan