Skip to content

DOC Release highlights 1.5 #29007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 20, 2024
Merged

DOC Release highlights 1.5 #29007

merged 10 commits into from
May 20, 2024

Conversation

jeremiedbb
Copy link
Member

@jeremiedbb jeremiedbb commented May 13, 2024 •
edited
Loading

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 13, 2024 •
edited
Loading

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 5bdc853. Link to the linter CI: here

betatim
betatim reviewed May 17, 2024
View reviewed changes
Copy link
Member

@betatim betatim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Two little grammar comments

@jeremiedbb jeremiedbb changed the title [WIP] Release highlights 1.5 DOC Release highlights 1.5 May 17, 2024
@jeremiedbb @glemaitre
Apply suggestions from code review
e516746 
Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
glemaitre
glemaitre approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only nitpicks. LGTM.

@jeremiedbb @glemaitre
Apply suggestions from code review
444218b 
Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
lorentzenchr
lorentzenchr approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together. Mostly optional suggestions.

examples/release_highlights/plot_release_highlights_1_5_0.py
# <sphx_glr_auto_examples_model_selection_plot_cost_sensitive_learning.py>`.

# %%
# Performance improvements in PCA
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not actionable: I know we are a bit thin with big new things and this is one of them. But we did not list the newton-cholesky solver in 1.2 as a highlight.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have promoted the newton-cholesky in 1.2.

If I put on my "developer relationships" hat on, I would add a new entry for newton-cholesky solver in the 1.2 highlights and link to it in the 1.5 highlights.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we did not list the newton-cholesky solver in 1.2 as a highlight.

It could have but all the reviewers for the 1.2 highlights missed it, including me. That said there were already many entries in the 1.2 highlights and there's always a compromise to make.

I would add a new entry for newton-cholesky solver in the 1.2 highlights and link to it in the 1.5 highlights.

I don't think adding a new entry today in the 1.2 highlights is relevant. It's already not even accessible from the front page. I expect a very low traffic on this page now.

@lorentzenchr
Copy link
Member

@scikit-learn/core-devs ping in case you want to have a look.

jeremiedbb and others added 2 commits May 20, 2024 10:29
@jeremiedbb @lorentzenchr
Update examples/release_highlights/plot_release_highlights_1_5_0.py
d8cb520 
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
@jeremiedbb
address comments
5bdc853
@jeremiedbb jeremiedbb mentioned this pull request May 20, 2024
Merged
14 tasks
@jeremiedbb
Copy link
Member Author

jeremiedbb commented May 20, 2024 •
edited
Loading

Alright, let's merge to not delay the release. If we want to do something about #29007 (comment), we can still open a separate PR and backport in 1.5.X, it's just doc anyway.

@jeremiedbb jeremiedbb merged commit be5316f into scikit-learn:main May 20, 2024
30 checks passed
jeremiedbb added a commit to jeremiedbb/scikit-learn that referenced this pull request May 20, 2024
@jeremiedbb @betatim
@glemaitre @lorentzenchr
DOC Release highlights 1.5 (scikit-learn#29007)
8854252 
Co-authored-by: Tim Head <betatim@gmail.com>
Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
jeremiedbb added a commit that referenced this pull request May 21, 2024
@jeremiedbb @betatim
@glemaitre @lorentzenchr
DOC Release highlights 1.5 (#29007)
0ac28ad 
Co-authored-by: Tim Head <betatim@gmail.com>
Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betatim betatim betatim left review comments

@thomasjpfan thomasjpfan thomasjpfan left review comments

@lorentzenchr lorentzenchr lorentzenchr approved these changes

@glemaitre glemaitre glemaitre approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeremiedbb @lorentzenchr @betatim @thomasjpfan @glemaitre