Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOC Release highlights 1.5 #29007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC Release highlights 1.5 #29007
Changes from all commits
5f7d6ef
9f10c23
f11be22
42f2b7a
524204b
e516746
444218b
19f17bc
d8cb520
5bdc853
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not actionable: I know we are a bit thin with big new things and this is one of them. But we did not list the newton-cholesky solver in 1.2 as a highlight.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should have promoted the newton-cholesky in 1.2.
If I put on my "developer relationships" hat on, I would add a new entry for newton-cholesky solver in the 1.2 highlights and link to it in the 1.5 highlights.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could have but all the reviewers for the 1.2 highlights missed it, including me. That said there were already many entries in the 1.2 highlights and there's always a compromise to make.
I don't think adding a new entry today in the 1.2 highlights is relevant. It's already not even accessible from the front page. I expect a very low traffic on this page now.